[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.h:108
 
+  Optional<ParamLoadedValue> describeLoadedValue(const MachineInstr &MI,
+                                                 Register Reg) const override;
----------------
vsk wrote:
> aprantl wrote:
> > doxygen comment?
> I'm not sure what's best to add, here. It looks like the practice has been to copy the doxygen comment from the base class virtual method declaration, but then the documentation could get out of sync.
Sorry, I missed the `override`! I'm actually against adding comments to override methods unless they do something unexpected that is not documented in the base class.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75273/new/

https://reviews.llvm.org/D75273