[PATCH] D65593: [Attributor] Deduction based on path exploration

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1342
 
+  void operator+=(const IntegerStateBase<base_t, BestState, WorstState> &R) {
+    handleNewKnownValue(R.getKnown());
----------------
We need Documentation for this.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1065
     return BeforeState == S ? ChangeStatus::UNCHANGED : ChangeStatus::CHANGED;
   }
 
----------------
Can you explain the NOTE further and why we cannot make it "right"?

---

Do you really want to delete `UsesInChild` or do you want to use it in the `followUsesInContext` call such that `Uses` is not modifed here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65593/new/

https://reviews.llvm.org/D65593