[PATCH] D65593: [Attributor] Deduction based on path exploration
Hideto Ueno via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 26 02:22:53 PST 2020
uenoku marked an inline comment as done.
uenoku added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1050-1051
+
+ SetVector<const Use *> UsesInChild = Uses;
+ followUsesInContext(A, Explorer, &BB->front(), UsesInChild, ChildState);
+
----------------
baziotis wrote:
> uenoku wrote:
> > baziotis wrote:
> > > This `UsesInChild` I think is not used anywhere. Probably put there since something has to be passed to the function. Can we do something to avoid inserting to it and deleting in every loop? (If I haven't missed something)
> > Yes, that's right.
> Thanks for addressing this. I think it still isn't used though right? i.e. With your update, it seems you can just remove `UsesInChild` declaration completely.
Oh, I forgot to remove it ;)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65593/new/
https://reviews.llvm.org/D65593
More information about the llvm-commits
mailing list