[PATCH] D75247: [mlir] fix wrong symbol order in AffineApplyNormalizer

Thu Feb 27 09:00:02 PST 2020

nicolasvasilache added subscribers: albertcohen, andydavis1.
nicolasvasilache added a comment.

> Making and pushing IR design decisions because there is buggy code based on incorrect assumptions (along with matching incorrect test cases) sounds hilarious to me! :-)

I think you misspelled "unnecessary cognitive overhead" :)
In any case I don't see what convoluted logic results in the implication `bug => IR design decision`.

The non-fallacious logic is `IR design => unnecessary cognitive overhead => consider changing IR design` :)
There are many places in affine that have been guilty of that historically and some are remaining today.
This particular one has been around for a lot of time.

The bug fix is one thing that goes in regardless.

Adding others to visibility: @albertcohen @andydavis1

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75247/new/

https://reviews.llvm.org/D75247