[PATCH] D75247: [mlir] fix wrong symbol order in AffineApplyNormalizer

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

In D75247#1895307 <https://reviews.llvm.org/D75247#1895307>, @ftynse wrote:

> I only replicated the IR that exhibited the buggy behavior. Same problem would have happened with affine.load(affine.apply) or any other composition. Same problem would have also happened if parts of this code were used for folding-on-construction.


+1 to @ftynse. Absolutely! One needs in-memory composition and compose/fold in by construction - both for creating IR and for analysis. Making and pushing IR design decisions because there is buggy code based on incorrect assumptions sounds hilarious to me! :-) And in any case, the fundamental need for compositions of maps with operands isn't avoided by just restricting what the printed/parsed IR represents.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75247/new/

https://reviews.llvm.org/D75247