[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

[Vedant Kumar via Phabricator via llvm-commits]

vsk accepted this revision.
vsk added a comment.

LGTM



================
Comment at: llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-expr-chain.mir:104
+# The MIR has been hand-modified to build up the call site values using chains
+# of ADDXri/SUBXri instructions instead of a single instructionper parameter.
+
----------------
nit, instruction per


================
Comment at: llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-expr-chain.mir:108
+# CHECK-NEXT: DW_AT_location (DW_OP_reg2 W2)
+# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg19 W19+700, DW_OP_plus_uconst 0x9, DW_OP_plus_uconst 0x50)
+
----------------
Nice!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036