[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:615
+        (Param.Expr->getNumElements() > 0)
+            ? DIExpression::append(Expr, Param.Expr->getElements())
+            : Expr;
----------------
dstenb wrote:
> vsk wrote:
> > Does this implicitly assert !Expr->isEntryValue()?
> Ah, yes. I did not consider that any `describeLoadedValue` implementation would may want to emit entry value expressions, but I guess it's fair for them to be able to do that.
> 
> This will bail out later due to a failed isValid() check, but I can add an explicit assert here instead.
I added isValid() asserts to both places where the debug expressions are combined.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036