[PATCH] D75195: [mlir][spirv] Add some folders for spv.LogicalAnd/spv.LogicalOr

[River Riddle via Phabricator via llvm-commits]

rriddle accepted this revision.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp:29
+/// the given `boolVal`.
+static bool isScalarOrSplatBoolAttr(Attribute boolAttr, bool boolVal) {
+  if (!boolAttr)
----------------
Would it be better to change this to something like:

`static Optional<bool> getScalarOrSplatBoolAttr(Attribute boolAttr)`

to avoid doing the same checks twice in each of the folders?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75195/new/

https://reviews.llvm.org/D75195