[PATCH] D75195: [mlir][spirv] Add some folders for spv.LogicalAnd/spv.LogicalOr

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/SPIRVCanonicalization.cpp:41
+      if (auto attr = boolAttr.dyn_cast<SplatElementsAttr>())
+        return attr.getSplatValue().template cast<BoolAttr>().getValue() ==
+               boolVal;
----------------
Is the `template` here really necessary? Also, please use `getSplatValue<bool>()` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75195/new/

https://reviews.llvm.org/D75195