[PATCH] D75126: [AIX] Extend integer arguments to register width when passed in stack memory.

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm marked an inline comment as done.
cebowleratibm added a comment.

In D75126#1891669 <https://reviews.llvm.org/D75126#1891669>, @ZarkoCA wrote:

> It would be better if the test cleanup was done in a separate patch to make it clearer what the expected output of the patch. But that said, it's not difficult to find added testcase and it would be ok with me to leave the modified test cases.


I agree many of the test updates could be a separate NFC patch.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6821
 
+  if (ValVT.isInteger() && (ValVT.getSizeInBits() > RegVT.getSizeInBits()))
+    report_fatal_error("Unexpected argument exceeds word size.");
----------------
ZarkoCA wrote:
> Suggestion: Move this error to line 6818, just after all the variable declarations required, or make this the last error (i.e. move to line 6832 and have the declarations just above it). 
I preferred to keep the errors as a block.  I needed to move some basic variable setup above the error block.  I can move this error later in the sequence but I wouldn't move the variable setup into the error block, so this wouldn't buy anything.  I prefer to keep the current approach.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75126/new/

https://reviews.llvm.org/D75126