[PATCH] D75126: [AIX] Extend integer arguments to register width when passed in stack memory.

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 09:21:03 PST 2020


ZarkoCA added a comment.
Herald added a subscriber: wuzish.

It would be better if the test cleanup was done in a separate patch to make it clearer what the expected output of the patch. But that said, it's not difficult to find added testcase and it would be ok with me to leave the modified test cases.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6821
 
+  if (ValVT.isInteger() && (ValVT.getSizeInBits() > RegVT.getSizeInBits()))
+    report_fatal_error("Unexpected argument exceeds word size.");
----------------
Suggestion: Move this error to line 6818, just after all the variable declarations required, or make this the last error (i.e. move to line 6832 and have the declarations just above it). 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75126/new/

https://reviews.llvm.org/D75126





More information about the llvm-commits mailing list