[PATCH] D74968: [XCOFF] Handle MCSA_LGlobal in emitSymbolAttribute

[Jason Liu via Phabricator via llvm-commits]

jasonliu accepted this revision.
jasonliu added a comment.

Some nit comments. Otherwise, LGTM.



================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:13
 
+#include "llvm/MC/MCXCOFFStreamer.h"
 #include "llvm/BinaryFormat/XCOFF.h"
----------------
Why do we move this "#include" here?


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:359
+    // If the symbol is a label, don't put it in the symbol table is it's not
+    // supposed to be external.
+    if (!XSym->isExternal())
----------------
nit: Maybe avoid double negate? 
Suggestion:
Only put label into the symbol table when it is an external label. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74968/new/

https://reviews.llvm.org/D74968