[PATCH] D74968: [XCOFF] Handle MCSA_LGlobal in emitSymbolAttribute

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 09:51:21 PST 2020


daltenty marked an inline comment as done.
daltenty added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:16
 #include "llvm/MC/MCCodeEmitter.h"
+#include "llvm/MC/MCDirectives.h"
 #include "llvm/MC/MCObjectWriter.h"
----------------
jasonliu wrote:
> Do we need this include at all?
This should probably be here to include what we use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74968/new/

https://reviews.llvm.org/D74968





More information about the llvm-commits mailing list