[PATCH] D73777: [SCEV][IndVars] Always provide insertion point to the SCEVExpander::isHighCostExpansion()

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D73777#1890718 <https://reviews.llvm.org/D73777#1890718>, @mkazantsev wrote:

> LGTM. Hope it doesn't end up exploding. :)


Thank you **so** much for reviewing this patch set!
We'll find out whether this explodes soon :)



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolutionExpander.h:184
                              const TargetTransformInfo *TTI,
-                             const Instruction *At = nullptr) {
+                             const Instruction *At) {
       assert(TTI && "This function requires TTI to be provided.");
----------------
mkazantsev wrote:
> Should we assert that provided `At` is not null, or there are other places where it'd be OK?
Hm, such an assertion does not fail as of `check-llvm`, so let's do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73777/new/

https://reviews.llvm.org/D73777