[PATCH] D73777: [SCEV][IndVars] Always provide insertion point to the SCEVExpander::isHighCostExpansion()
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 22:16:48 PST 2020
mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.
LGTM. Hope it doesn't end up exploding. :)
================
Comment at: llvm/include/llvm/Analysis/ScalarEvolutionExpander.h:184
const TargetTransformInfo *TTI,
- const Instruction *At = nullptr) {
+ const Instruction *At) {
assert(TTI && "This function requires TTI to be provided.");
----------------
Should we assert that provided `At` is not null, or there are other places where it'd be OK?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73777/new/
https://reviews.llvm.org/D73777
More information about the llvm-commits
mailing list