[PATCH] D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added a comment.

In D74764#1888953 <https://reviews.llvm.org/D74764#1888953>, @jhenderson wrote:

> Two comment-related nits from me.


Thanks, I've addressed them in https://reviews.llvm.org/rG157b3d505f6

> Also, not worth fixing them now, but in some of those tests, we probably didn't need to check the actual address value at all, so they could have been replaced with {{.*}} or similar.

In some of them the check for address seems to be useful thing. Like in llvm-readobj tests where we now checking that we dump addresses properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74764/new/

https://reviews.llvm.org/D74764