[PATCH] D74764: [yaml2obj] - Automatically assign sh_addr for allocatable sections.

Mon Feb 24 04:05:47 PST 2020

jhenderson added a comment.

Sorry, I didn't get a chance to look at this earlier. It's been a pretty hectic few days. Two comment-related nits from me.

Also, not worth fixing them now, but in some of those tests, we probably didn't need to check the actual address value at all, so they could have been replaced with {{.*}} or similar.

================
Comment at: llvm/lib/ObjectYAML/ELFEmitter.cpp:710-711

   // If the section is explicitly described in the YAML
   // then we want to use its section address.
+  assignSectionAddress(SHeader, YAMLSec);
----------------
Nit: this comment looks stale now.

================
Comment at: llvm/test/tools/yaml2obj/ELF/section-address-assign.yaml:86
+    Size:  0x1
+## Show we can return back in the address space and
+## continue placing sections. The order of sections in the
----------------
I think you mean "go back" not "return back".

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74764/new/

https://reviews.llvm.org/D74764