[PATCH] D71337: [VE] Target-specific bit size for sjljehprepare

[Simon Moll via Phabricator via llvm-commits]

simoll planned changes to this revision.
simoll marked 2 inline comments as done.
simoll added a comment.

Thanks for having a look :)



================
Comment at: llvm/test/CodeGen/VE/sjlj_except.ll:1-2
+; RUN: llc  -mtriple=x86_64-unknown-unknown --exception-model=sjlj --print-after=sjljehprepare < %s |& FileCheck --check-prefix=CHECK-X86 %s
+; RUN: (llc  -mtriple=ve-unknown-unknown --exception-model=sjlj  --print-after=sjljehprepare < %s || true) |& FileCheck --check-prefix=CHECK-VE %s
+
----------------
arsenm wrote:
> You should be able to test this with just opt running the pass? You certainly don't need to rely on -print-after
I was hoping to do that. However, when the pass is created without a target machine (as happens in opt) - it defaults to the standard bit size. Since VE is the only target that actually uses a non-default value, i found no other way to test it than to go all the way to VE codegen.


================
Comment at: llvm/test/CodeGen/VE/sjlj_except.ll:13
+
+define dso_local i32 @foo(i32 %arg) local_unnamed_addr personality i8* bitcast (i32 (...)* @__gxx_personality_sj0 to i8*) {
+; CHECK-VE: *** IR Dump After SJLJ Exception Handling preparation ***
----------------
arsenm wrote:
> I don't know anything about SJLJ but I would guess it's possible to shrink this test more?
Probably. I'll look into it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71337/new/

https://reviews.llvm.org/D71337