[PATCH] D71337: [VE] Target-specific bit size for sjljehprepare

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/VE/sjlj_except.ll:1-2
+; RUN: llc  -mtriple=x86_64-unknown-unknown --exception-model=sjlj --print-after=sjljehprepare < %s |& FileCheck --check-prefix=CHECK-X86 %s
+; RUN: (llc  -mtriple=ve-unknown-unknown --exception-model=sjlj  --print-after=sjljehprepare < %s || true) |& FileCheck --check-prefix=CHECK-VE %s
+
----------------
You should be able to test this with just opt running the pass? You certainly don't need to rely on -print-after


================
Comment at: llvm/test/CodeGen/VE/sjlj_except.ll:13
+
+define dso_local i32 @foo(i32 %arg) local_unnamed_addr personality i8* bitcast (i32 (...)* @__gxx_personality_sj0 to i8*) {
+; CHECK-VE: *** IR Dump After SJLJ Exception Handling preparation ***
----------------
I don't know anything about SJLJ but I would guess it's possible to shrink this test more?


================
Comment at: llvm/test/CodeGen/VE/sjlj_except.ll:32
+  %error = landingpad { i8*, i32 }
+          catch i8* bitcast ({ i8*, i8*, i8* }* @_ZTI10SomeExcept to i8*)
+  %err.tyd = extractvalue { i8*, i32 } %error, 1
----------------
Weird indent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71337/new/

https://reviews.llvm.org/D71337