[PATCH] D74023: [RISCV] ELF attribute section for RISC-V
Hsiangkai Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 23 21:56:51 PST 2020
HsiangKai added a comment.
In D74023#1888122 <https://reviews.llvm.org/D74023#1888122>, @MaskRay wrote:
> `ARMAttributeParser` has lots of boilerplate code and many untested parsing errors. I think we should improve the existing interface so that the newly added RISCVAttributeParser will not add another sets of untested code paths.
>
> `ARMAttributeParser` can be simplified a lot by leverating `DataExtractor`. So I created D75015 <https://reviews.llvm.org/D75015>.
If your patch is accepted, I will rebase this patch based on your improvement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74023/new/
https://reviews.llvm.org/D74023
More information about the llvm-commits
mailing list