[PATCH] D74023: [RISCV] ELF attribute section for RISC-V
Hsiangkai Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 23 21:39:02 PST 2020
HsiangKai marked an inline comment as done.
HsiangKai added inline comments.
================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:308
+ default:
+ llvm_unreachable("Unknown extension in Arch attribute.");
+ case 'i':
----------------
MaskRay wrote:
> The `defualt` branch is still reachable, thus it is incorrect to use llvm_unreachable.
> You may want to return an Error.
Encoding part only accepts `iemafdc`. Decoding part should expect these features only. Default case should be unreachable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74023/new/
https://reviews.llvm.org/D74023
More information about the llvm-commits
mailing list