[PATCH] D74691: [Attributor] Detect SCCs with unbounded cycles

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2369
 
-// Helper function that checks whether a function has any cycle.
 // TODO: Replace with more efficent code
----------------
lebedev.ri wrote:
> The old comment is strictly more understandable.
> New comment does not mention at all that we are checking inside functions only.
Yeah, the addition that we check inside a function would be good. Otherwise, I think the new one is clearer on what it is considered an unbounded cycle in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691