[PATCH] D74691: [Attributor] Detect SCCs with unbounded cycles

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

The patch description is not very useful.
It should actually explain the patch, and why that is the correct solution.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2369
 
-// Helper function that checks whether a function has any cycle.
 // TODO: Replace with more efficent code
----------------
The old comment is strictly more understandable.
New comment does not mention at all that we are checking inside functions only.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2388
+      continue;
+    // When NoAnalysis available then check only if the SCC has loop or not.
+    if (NoAnalysis && SCCHasLoop)
----------------
s/if/whether/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691