[PATCH] D74954: Add a basic tiling pass for parallel loops

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 05:11:53 PST 2020


ftynse added a subscriber: poechsel.
ftynse added a comment.

We already several implementations of loop tiling (lib/Transforms/LoopTiling.cpp, lib/Dialect/Linalg/Transforms/Tiling.cpp, lib/Transforms/Utils/LoopUtils.cpp). Have you considered generalizing them instead of introducing yet another one?  I suppose parallel loop nest as an operation removes the need for any supplementary preconditions, but the mechanics of the transformation should be very similar between parallel and sequential loops.

I agree we may want to peel off the last iterations to avoid complex conditions, but IMO it's better as an option to the transformation. @poechsel had a similar requested with loops produced by Linalg tiling, so it would make sense to try and reuse the infra here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74954/new/

https://reviews.llvm.org/D74954





More information about the llvm-commits mailing list