[PATCH] D74954: Add a basic tiling pass for parallel loops

[Alex Zinenko via Phabricator via llvm-commits]

ftynse requested changes to this revision.
ftynse added inline comments.


================
Comment at: mlir/test/Dialect/Loops/parallel-loop-tiling.mlir:19
+// CHECK: func @parallel_loop(%arg0: index, %arg1: index, %arg2: index, %arg3: index, %arg4: index, %arg5: index, %arg6: memref<?x?xf32>, %arg7: memref<?x?xf32>, %arg8: memref<?x?xf32>, %arg9: memref<?x?xf32>) {
+// CHECK:   %c0 = constant 0 : index
+// CHECK:   %c4 = constant 4 : index
----------------
Please don't pattern-match SSA names, and generally prefer avoiding non-essential parts of the IR from the test (e.g. repeated types in the pattern).

https://mlir.llvm.org/getting_started/TestingGuide/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74954/new/

https://reviews.llvm.org/D74954