[PATCH] D74946: [llvm-objcopy][MachO] Change the storage of sections.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 21:15:21 PST 2020


alexshap created this revision.
alexshap added reviewers: MaskRay, seiya, jhenderson.
Herald added a reviewer: rupprecht.
Herald added a subscriber: abrachet.
Herald added a project: LLVM.
alexshap edited the summary of this revision.

In this diff we change the storage of a section to unique_ptr to avoid pointer invalidation in case of adding/removing new sections.
This refactoring is factored out from D71647 <https://reviews.llvm.org/D71647>.

Test plan: make check-all


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74946

Files:
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/Object.cpp
  llvm/tools/llvm-objcopy/MachO/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74946.245784.patch
Type: text/x-patch
Size: 14748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200221/cc88123a/attachment.bin>


More information about the llvm-commits mailing list