[PATCH] D74306: [MIR][ARM] MachineOperand comments to print condition code names instead of constants

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 00:39:28 PST 2020


SjoerdMeijer updated this revision to Diff 245595.
SjoerdMeijer added a comment.

Thanks again for the suggestions/comments. The MachineOperand comments are now enclosed between `/*` and `*/`, see the only test file that I have uploaded.

As a last step, I can now change all tests. I can upload them here, or commit directly when you're happy with this patch. The only reason I have not uploaded the ~140 changed tests, is because that makes this Phab diff a bit unwieldy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74306/new/

https://reviews.llvm.org/D74306

Files:
  llvm/include/llvm/CodeGen/TargetInstrInfo.h
  llvm/lib/CodeGen/MIRParser/MILexer.cpp
  llvm/lib/CodeGen/MIRPrinter.cpp
  llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
  llvm/lib/Target/ARM/ARMBaseInstrInfo.h
  llvm/test/CodeGen/Thumb2/t2-teq-reduce.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74306.245595.patch
Type: text/x-patch
Size: 13363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200220/0f51a8a1/attachment.bin>


More information about the llvm-commits mailing list