[PATCH] D74192: [WebAssembly] Replace all calls with generalized multivalue calls

[Thomas Lively via Phabricator via llvm-commits]

tlively marked 2 inline comments as done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp:80
     }
   }
 
----------------
aheejin wrote:
> Can we add a test that prints multivalue calls w/ `-wasm-keep-registers` and `-wasm-explicit-locals` on? I don't think this part is being tested for multivalue calls.
Sure, will add a new test mode to multivalue.ll.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrCall.td:70
 
-let isCodeGenOnly = 1 in
-defm PCALL_INDIRECT_VOID :
-  I<(outs), (ins I32:$callee, variable_ops),
-    (outs), (ins I32:$callee),
-    [(WebAssemblycall0 I32:$callee)],
-    "PSEUDO CALL INDIRECT\t$callee",
-    "PSEUDO CALL INDIRECT\t$callee">;
-
-defm CALL_INDIRECT_VOID :
-  I<(outs), (ins TypeIndex:$type, i32imm:$flags, variable_ops),
-    (outs), (ins TypeIndex:$type, i32imm:$flags),
-    [],
-    "call_indirect\t", "call_indirect\t$type",
-    0x11>;
-
-let isReturn = 1 in
+let isReturn = 1, usesCustomInserter = 1 in
 defm RET_CALL_INDIRECT :
----------------
aheejin wrote:
> Why `usesCustomInserter` for `RET_CALL_INDIRECT`?
Good catch. This is unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74192/new/

https://reviews.llvm.org/D74192