[PATCH] D74803: TableGen: Fix logic for default operands

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 21:15:57 PST 2020


arsenm added a comment.

In D74803#1883340 <https://reviews.llvm.org/D74803#1883340>, @dsanders wrote:

> I haven't dug very deep into this but it makes sense to me to be reading the InstInfo and as Simon notes, they should be identical for the cases that already work. On that basis LGTM
>
> Could you add a small test case to the TableGen directory? We don't have much information about how default operands behave and a couple easy to find examples would help with that.


Oddly this seems to only break if the same instruction is used in two different pattern contexts, one using the override and one not. I would expect these to be independent


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74803/new/

https://reviews.llvm.org/D74803





More information about the llvm-commits mailing list