[PATCH] D74471: [AArch64][SVE] Add predicate reinterpret intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:3055
+    // Return the reintepret if the cast isn't changing type,
+    // i.e. <n x 16 x i1> -> <n x 16 x i1>
+    if (VT == Op.getOperand(1).getValueType())
----------------
If the conversion isn't changing the type, do you need a REINTERPRET_CAST at all?


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret.ll:33
+  ret <vscale x 16 x i1> %out
+}
+
----------------
Are you sure the explicit zeroing is working correctly?  It looks like reinterpret_bool_h2b and reinterpret_bool_s2b are generating the same code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74471/new/

https://reviews.llvm.org/D74471