[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:102
+
+    Streamer.EmitIntValue(ELFBuildAttrs::Format_Version, 1);
+  }
----------------
HsiangKai wrote:
> pzheng wrote:
> > should be "Streamer.emitIntValue"
> > 
> > same for all other "Streamer.emitXXX" references
> The interface is defined by MCStreamer.
These `MCStreamer::Emit*` functions have been de-capitalized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023