[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai marked 2 inline comments as done.
HsiangKai added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:102
+
+    Streamer.EmitIntValue(ELFBuildAttrs::Format_Version, 1);
+  }
----------------
pzheng wrote:
> should be "Streamer.emitIntValue"
> 
> same for all other "Streamer.emitXXX" references
The interface is defined by MCStreamer.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:64
+
+  void EmitStartOfAsmFile(Module &M) override;
+  void EmitEndOfAsmFile(Module &M) override;
----------------
pzheng wrote:
> should be emitStartOfAsmFile ?
The interface is defined in AsmPrinter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023