[PATCH] D74748: [XCore] Add instruction pattern for bitrev

[Jim Lin via Phabricator via llvm-commits]

Jim marked an inline comment as done.
Jim added inline comments.


================
Comment at: llvm/lib/Target/XCore/XCoreInstrInfo.td:892
                        "bitrev $dst, $src",
                        [(set GRRegs:$dst, (int_xcore_bitrev GRRegs:$src))]>;
 
----------------
RKSimon wrote:
> Should you remove int_xcore_bitrev and use bitreverse directly? AFAICT xcore does this in LowerINTRINSIC_WO_CHAIN for crc8?
int_xcore_bitrev (intrinsic node from llvm.xcore.bitrev) has to be matched bitrev instruction.
It looks like unable to be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74748/new/

https://reviews.llvm.org/D74748