[PATCH] D74748: [XCore] Add instruction pattern for bitrev

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 05:36:29 PST 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/XCore/XCoreInstrInfo.td:892
                        "bitrev $dst, $src",
                        [(set GRRegs:$dst, (int_xcore_bitrev GRRegs:$src))]>;
 
----------------
Should you remove int_xcore_bitrev and use bitreverse directly? AFAICT xcore does this in LowerINTRINSIC_WO_CHAIN for crc8?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74748/new/

https://reviews.llvm.org/D74748





More information about the llvm-commits mailing list