[PATCH] D74700: [IR] Remove temporary const operator created in Value::getPointerAlignment()

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 14:53:18 PST 2020


efriedma added a comment.

The general rule for IR passes is that dangling constants may exist, and transformations are expected to correctly handle them (ignore or erase them, as appropriate).  So creating them should be harmless across IR passes.

That's not really an excuse for IR queries that don't obviously involve creating constants to do so, though: it could be confusing within a pass.  For example, if a pass is trying to iterate over a use list, and asking for the alignment modifies that use list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74700/new/

https://reviews.llvm.org/D74700





More information about the llvm-commits mailing list