[PATCH] D74700: [IR] Remove temporary const operator created in Value::getPointerAlignment()

Mikhail Lychkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 06:52:35 PST 2020


mlychkov added a comment.

When reading the following definition of method 'MaybeAlign Value::**get**PointerAlignment(const DataLayout &DL) **const**' most users assume that Value won't be modified by this method. If we don't guarantee it then it would be nice to remove const-qualifier and change name on something like 'accountPointerAlignment'. As renaming is less possible then a comment might be present that this method may change an IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74700/new/

https://reviews.llvm.org/D74700





More information about the llvm-commits mailing list