[PATCH] D74346: Flags for displaying only hot nodes in CFGPrinter graph

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 02:23:26 PST 2020


fedor.sergeev added a comment.

In D74346#1877375 <https://reviews.llvm.org/D74346#1877375>, @apilipenko wrote:

> In D74346#1873034 <https://reviews.llvm.org/D74346#1873034>, @davidxl wrote:
>
> > what is the use case of these options?  Do hidden nodes create too much noise?
>
>
> This is mostly for performance analysis. In our compiler we end up with many code paths resulting in deoptimization. These code paths are supposed to be cold and are not interesting when we are looking for the "fast path" performance. Filtering these has a nice effect of streamlining the CFG to the common path only.


Makes sense to add rationale like this as a paragraph to revision description.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74346/new/

https://reviews.llvm.org/D74346





More information about the llvm-commits mailing list