[PATCH] D74654: Don't call computeHostNumPhysicalCores when LLVM_ENABLE_THREADS is off

[Alexandre Ganea via llvm-commits]

I’ll take a look later tonight.
Alex.
________________________________
De : Reid Kleckner via Phabricator <reviews at reviews.llvm.org>
Envoyé : 14 février 2020 18:52
À : akhuang at google.com <akhuang at google.com>; Alexandre Ganea <alexandre.ganea at ubisoft.com>
Cc : hiraditya at msn.com <hiraditya at msn.com>; llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>; zturner at roblox.com <zturner at roblox.com>
Objet : [PATCH] D74654: Don't call computeHostNumPhysicalCores when LLVM_ENABLE_THREADS is off

rnk added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1329
 }
-#elif defined(_WIN32)
+#elif defined(_WIN32) && LLVM_THREADS_ENABLED
 // Defined in llvm/lib/Support/Windows/Threading.inc
----------------
As we discovered later, this should be spelled `LLVM_ENABLE_THREADS != 0`, and something needs to be done to fix SupportTests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74654/new/

https://reviews.llvm.org/D74654



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200215/e063d4d1/attachment.html>