<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
I’ll take a look later tonight.
<div>Alex.</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>De :</b> Reid Kleckner via Phabricator <reviews@reviews.llvm.org><br>
<b>Envoyé :</b> 14 février 2020 18:52<br>
<b>À :</b> akhuang@google.com <akhuang@google.com>; Alexandre Ganea <alexandre.ganea@ubisoft.com><br>
<b>Cc :</b> hiraditya@msn.com <hiraditya@msn.com>; llvm-commits@lists.llvm.org <llvm-commits@lists.llvm.org>; zturner@roblox.com <zturner@roblox.com><br>
<b>Objet :</b> [PATCH] D74654: Don't call computeHostNumPhysicalCores when LLVM_ENABLE_THREADS is off</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">rnk added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/Support/Host.cpp:1329<br>
}<br>
-#elif defined(_WIN32)<br>
+#elif defined(_WIN32) && LLVM_THREADS_ENABLED<br>
// Defined in llvm/lib/Support/Windows/Threading.inc<br>
----------------<br>
As we discovered later, this should be spelled `LLVM_ENABLE_THREADS != 0`, and something needs to be done to fix SupportTests<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D74654/new/">https://reviews.llvm.org/D74654/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D74654">https://reviews.llvm.org/D74654</a><br>
<br>
<br>
<br>
</div>
</span></font></div>
</body>
</html>