[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 14 14:30:11 PST 2020


tmsriram added a comment.

In D73674#1868439 <https://reviews.llvm.org/D73674#1868439>, @efriedma wrote:

> I'm afraid the way this patch is written, we're going to have to substantially rewrite it to port to other targets.  In particular, we're assigning blocks to sections in the asmprinter, which is way too late for targets that do branch relaxation as an MIR pass.


Hi Eli, What do you suggest we do here? An MIR pass that assigns sections to basic blocks?

> Is there some reason to emit "cold" and "exception" blocks into separate sections?  Not sure what benefit you get from separating them.

Sections containing hot blocks can be grouped together, function splitting of cold basic blocks and placing all the cold blocks together and away from the hot blocks gives us better iTLB utilization.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73674/new/

https://reviews.llvm.org/D73674





More information about the llvm-commits mailing list