[PATCH] D73674: Propeller: LLVM support for basic block sections (Base Patch - Part 2)
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 11 15:08:27 PST 2020
rahmanl added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:3030
+ if (MBB.isExceptionSection()) {
+ if (MF->front().isExceptionSection()) {
+ OutStreamer->SwitchSection(MF->getSection());
----------------
efriedma wrote:
> I'm confused what `MF->front().isExceptionSection()` is supposed to check. The entry block can't be an exception handler, I think?
Great catch. This block should be removed. We'll remove it in the next update.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73674/new/
https://reviews.llvm.org/D73674
More information about the llvm-commits
mailing list