[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Thu Feb 13 22:43:29 PST 2020

mehdi_amini added a comment.

In D74211#1875514 <https://reviews.llvm.org/D74211#1875514>, @nicolasvasilache wrote:

> @dcaballe I don't think reverting the commit will be a reasonable path here, a bunch of other things and integrates have switched to this.
>
> The problem seems to be that the existing tests were not sufficiently covering the behavior you are interested in enforcing?
>  It seems the natural solution would be to fix those cases and add the proper tests to cover those behaviors?

If a fix can be quickly provided by the commit author, sure. Otherwise a few days after a breakage is introduced, reverting is absolutely the correct path.
(you need to revert 696f80736b861 <https://reviews.llvm.org/rG696f80736b861dfab5a7330dd009fd1d53b60356> along the way).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211