[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 18:19:52 PST 2020


nicolasvasilache added a comment.

@dcaballe I don't think reverting the commit will be a reasonable path here, a bunch of other things and integrates have switched to this.

The problem seems to be that the existing tests were not sufficiently covering the behavior you are interested in enforcing?
It seems the natural solution would be to fix those cases and add the proper tests to cover those behaviors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211





More information about the llvm-commits mailing list