[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

[Chirag Patel via Phabricator via llvm-commits]

Chirag added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:4171
+template <>
+bool LLParser::ParseMDField(LocTy Loc, StringRef Name, DIBTFlagField &Result) {
+
----------------
aprantl wrote:
> Could the bulk of the implementation of this function be shared with the function that parses DIFlag and DISPFlag?
Does using macro to generate flag LLParser seems like a good idea? it can be reused for other flags as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74470/new/

https://reviews.llvm.org/D74470