[PATCH] D74470: Seperated DIBasicType DIFlags to DIBTFlags.

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 00:32:24 PST 2020


djtodoro added a comment.

In D74470#1873714 <https://reviews.llvm.org/D74470#1873714>, @Chirag wrote:

> In D74470#1872492 <https://reviews.llvm.org/D74470#1872492>, @probinson wrote:
>
> > D73261 <https://reviews.llvm.org/D73261> would also benefit from moving more flags into the subprogram flags field.  The refactoring really should move out as many flags as possible all in one go.  I understand this is more than you anticipated but it will be the right thing to do for the project as a whole.
>
>
> I can create a separate small patches for other flags DIVarFlags/Mod DISPFlag it will be easier to track if something gets broken. (i am not fully aware of all the flags' complete use cases)


That would be awesome! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74470/new/

https://reviews.llvm.org/D74470





More information about the llvm-commits mailing list