[PATCH] D74154: LSAN for android

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:485
+                                   reinterpret_cast<void**>(&end_addr))){
+    fprintf(stderr, "Error getting TLS bounds\n");
+    *addr = 0;
----------------
oontvoo wrote:
> eugenis wrote:
> > Printf
> If the sanitizer crashes (which it does sometimes, mostly due to bugs) stuff going into printf() will not get printed - which makes it hard to debug.
This code needs to be async signal safe, which fprintf is not. What kinds of bugs do you have in mind? Printf goes almost directly to stderr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74154/new/

https://reviews.llvm.org/D74154