[PATCH] D74154: LSAN for android

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 19:37:33 PST 2020


oontvoo marked 2 inline comments as done.
oontvoo added a comment.

PTAL. Thanks!



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:485
+                                   reinterpret_cast<void**>(&end_addr))){
+    fprintf(stderr, "Error getting TLS bounds\n");
+    *addr = 0;
----------------
eugenis wrote:
> Printf
If the sanitizer crashes (which it does sometimes, mostly due to bugs) stuff going into printf() will not get printed - which makes it hard to debug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74154/new/

https://reviews.llvm.org/D74154





More information about the llvm-commits mailing list