[PATCH] D74226: [mlir][spirv] Introduce spv.function

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.h:49
+// spirv::Function ops hash just like pointers.
+template <> struct DenseMapInfo<mlir::spirv::FuncOp> {
+  static mlir::spirv::FuncOp getEmptyKey() {
----------------
mehdi_amini wrote:
> antiagainst wrote:
> > rriddle wrote:
> > > This needs to be formatted.
> > This is actually the result after running format fix internally. Maybe because clang-format version differences.
> Google internal does not honor .clang-format files: source of truth is the bot at the moment. Please use `git clang-format`
Oh that's good to know! Thanks Mehdi! I formatted this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74226/new/

https://reviews.llvm.org/D74226