[PATCH] D74226: [mlir][spirv] Introduce spv.function

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 11 21:51:26 PST 2020


mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVOps.h:49
+// spirv::Function ops hash just like pointers.
+template <> struct DenseMapInfo<mlir::spirv::FuncOp> {
+  static mlir::spirv::FuncOp getEmptyKey() {
----------------
antiagainst wrote:
> rriddle wrote:
> > This needs to be formatted.
> This is actually the result after running format fix internally. Maybe because clang-format version differences.
Google internal does not honor .clang-format files: source of truth is the bot at the moment. Please use `git clang-format`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74226/new/

https://reviews.llvm.org/D74226





More information about the llvm-commits mailing list