[PATCH] D74416: [llvm][TextAPI] add simulators to output

[Juergen Ributzka via Phabricator via llvm-commits]

ributzka added inline comments.


================
Comment at: llvm/lib/TextAPI/MachO/TextStubCommon.cpp:68
     break;
+  case PlatformKind::iOSSimulator:
+    OS << "ios";
----------------
cishida wrote:
> ributzka wrote:
> > You could simplify this to use fall-throughs for all the simulator platforms.
> wouldn't that trigger a warning with `-Wimplicit-fallthrough`?
You can use LLVM_FALLTHROUGH to silence that warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74416/new/

https://reviews.llvm.org/D74416